[ refactor ] make m ≤ n argument to Data.Vec.Base.{truncate|padRight} irrelevant#2787
Merged
MatthewDaggitt merged 18 commits intoagda:masterfrom Jan 24, 2026
Merged
Conversation
jamesmckinna
added
status: blocked-by-issue
jamesmckinna
changed the title
Data.Vec.Base.{truncate|padRight} take irrelevant m ≤ n argumentm ≤ n argument to make Data.Vec.Base.{truncate|padRight} irrelevant
jamesmckinna
changed the title
m ≤ n argument to make Data.Vec.Base.{truncate|padRight} irrelevantm ≤ n argument to Data.Vec.Base.{truncate|padRight} irrelevant
JacquesCarette
approved these changes
Aug 1, 2025
…e `truncate-irrelevant`
Collaborator
Author
Collaborator
Author
|
Revisiting this, I'm happy to badge this as |
jamesmckinna
removed
the
status: blocked-by-issue
Collaborator
Author
|
@MatthewDaggitt would you be happy with merging this? |
MatthewDaggitt
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackles #2770
Blocked on #2769 and #2795 , but could be merged into that PR instead.Refactored
Propertiesto take advantage of the revised definition(s), and the new properties.